Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for computed columns #463

Merged
merged 26 commits into from
Jul 23, 2024
Merged

Add support for computed columns #463

merged 26 commits into from
Jul 23, 2024

Conversation

gsreynolds
Copy link
Member

@gsreynolds gsreynolds commented Jul 11, 2024 •
edited
Loading

  • Add additional test for existing column generator functionality
  • Add regex-single and regex test for hostname in incident details
  • Add computed null condition tests
  • Add computed columns UI
  • Reduce duplication of values/ids/labels etc so they are defined in fewer places
  • Clear Local Cache should really clear local storage and session storage entirely
  • Ensure value is loaded from saved columns and ensure expression and expressionType are persisted as needed to set the accessor function
  • Remove redundant aggregator from alert columns, always null
  • Add validation to add column functions and set default state of columnType
  • react-table requires id, but derive it now from value and not accessor if id is not directly set
  • Column IDs are now the full value and not just the accessor
  • Add e2e test for adding computed columns
  • Update locales
  • Remove duplicated functions
  • Pass custom column as argument and construct value later. Improve e2e tests for alert and computed columns
  • Guard against computed or alert column state being undefined

@gsreynolds gsreynolds self-assigned this Jul 12, 2024
@gsreynolds gsreynolds requested a review from martindstone July 12, 2024 14:16
@gsreynolds gsreynolds added the enhancement New feature or request label Jul 12, 2024
@gsreynolds gsreynolds marked this pull request as ready for review July 17, 2024 17:22
@gsreynolds
Pass custom column as argument and construct value later. Improve e2e…
38ac483 
… tests for alert and computed columns

Signed-off-by: Gavin Reynolds <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 18, 2024
View reviewed changes
cypress/support/util/common.js Dismissed Show dismissed Hide dismissed
src/components/ColumnsModal/ColumnsModalComponent.jsx Dismissed Show dismissed Hide dismissed
martindstone
martindstone approved these changes Jul 19, 2024
View reviewed changes
Copy link

@martindstone martindstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@gsreynolds gsreynolds added this to the v0.13.1 milestone Jul 23, 2024
@gsreynolds gsreynolds merged commit 663ca78 into develop Jul 23, 2024
15 checks passed
@gsreynolds gsreynolds deleted the computed-columns branch July 23, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martindstone martindstone martindstone approved these changes

Assignees

@gsreynolds gsreynolds

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.13.1
Development

Successfully merging this pull request may close these issues.
2 participants
@gsreynolds @martindstone